Skip to content

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jan 22, 2026

Summary

Fixes up the engine client to implement the shared primitives engine trait.

@refcell refcell self-assigned this Jan 22, 2026
@refcell refcell added A-shared Area: shared crates K-cleanup Kind: general cleanup labels Jan 22, 2026
Base automatically changed from rf/engine-api-client to main January 22, 2026 02:37
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 22, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

…gine API

Introduces a transport-agnostic Engine API client trait that can be
implemented by both HTTP-based and in-process engine clients.

- Add EngineApiClient trait with core engine API methods
- Add EngineApiError and EngineApiResult types
- Update DirectEngineApi to compose with EngineApiClient
- Update LegacyPayloadSupport to use EngineApiResult

Co-Authored-By: Claude <noreply@anthropic.com>

fix ci

engine-ext
@refcell refcell force-pushed the rf/engine-ext-port branch from 06b2c12 to 5fbe288 Compare January 22, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-shared Area: shared crates K-cleanup Kind: general cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants