Open
Conversation
Owner
|
Thanks @comick for the pull request and test case! I'll be taking a deeper look at the functionality in the next few days. |
Owner
|
I reviewed the code @comick. I think your issue comes from another issue brought up about how method calls are treated as events. I've started planning out 2.0 of xmlrpc, which should allow for a less hacky way to handle messages, including those not found (a wildcard handler). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I'm working on some use cases when the availability of a method call is known only once the call has been triggered, so I've introduced the possibility to handle wildcard method calls (only server side) using the '*' character which is not valid for method names according to the XML-RPC standard. Unlike the standard callback, the wildcard handler takes two callbaks, one when the method is manageable, while the other (not found) when not. Sure, the code can describe the new behavior better. I've improved the example and added one test.
Thanks for the work on node-xmlrpc, hope this can help to improve it.
Michele.