Add latest intEnum and signature versions #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onno-vos-dev
force-pushed
the
fix-aws-codegen-after-recent-aws-models
branch
from
1a8a799 to
0197faf
Compare
onno-vos-dev
commented
Jan 27, 2026
|
|
||
| defp reserved_type(type) do | ||
| type == "node" || type == "term" || type == "function" || type == "reference" || type == "identifier" | ||
| type == "node" || type == "term" || type == "function" || type == "reference" || type == "identifier" || type == "none" || type == "none()" |
Member
Author
There was a problem hiding this comment.
It's a little bit funky to support none and none() here but it's a bit finicky to get these types to work properly and this at least covers the None type that AWS introduced recently so I'll let it be for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First "ticket" in order to get to work on: aws-beam/aws-elixir#223 since the codegen is currently broken...