Open
Conversation
Also update .gitignore and the 'lingo' submodule.
... since it is quite clearly supposed to represent a backslash, ^not^ a forward slash. I also reordered keyword token constants (e.g. Token_kind::abstract_kw) so that they appear in alphabetical order.
A nitpick that is strictly not necessary, but works for a broader range of types and takes advantage of constant folding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that none of the header files use the macros or functions in the configuration header, so it can effectively be made "private" (i.e., it will not be copied to the installation tree). I moved config.hpp.in to the root directory, removed the
BEAKER_prefix from the macros in the configuration header, and added#include "config.hpp"to all source files.I also updated .gitignore and the 'lingo' submodule.