ENH: Add timeout parameter to run_async method in tap module

[stvoutsin]

Description

This exposes the timeout parameter to the run_async method, allowing a user to specify a maximum runtime for an asynchronous query before it times out.

This closes issue #720

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.12%. Comparing base (fd99986) to head (0d97469).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   84.12%   84.12%           
=======================================
  Files          79       79           
  Lines        8616     8617    +1     
=======================================
+ Hits         7248     7249    +1     
  Misses       1368     1368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bsipocz]

Thank you, it all looks good to me.

I would still like to see one other approval and maybe opinions about the default 600s value, as well as if we consider this API change or bugfix -- whether to release nowish with 1.8.1 or later in May with 1.9

[ManonMarchand]

The 600s timeout is the same than in wait, so it doesn't change the previous behavior. It's true that duplicating the literal can lead to issues later though. Should we set a global variable?

[stvoutsin]

The 600s timeout is the same than in wait, so it doesn't change the previous behavior. It's true that duplicating the literal can lead to issues later though. Should we set a global variable?

Yea that seems like a good idea, I've set this as a global variable. Let me know if this looks better or if any other changes are needed to the PR.

[ManonMarchand]

Looks good to me.

It's not breaking anything, and such a tiny change that I'd release it in 1.8.1 if you're ok with that @bsipocz

[bsipocz]

It's not breaking anything, and such a tiny change that I'd release it in 1.8.1 if you're ok with that @bsipocz

OK, let's do it. I think I could argue (not a strong argument though) that this fixes a bug/problems we had with the IRSA notebooks.