Make BoxPredicate::find_case use the inner find_case#200
Open
rynoV wants to merge 3 commits intoassert-rs:masterfrom
Open
Make BoxPredicate::find_case use the inner find_case#200rynoV wants to merge 3 commits intoassert-rs:masterfrom
rynoV wants to merge 3 commits intoassert-rs:masterfrom
Conversation
Contributor
Note that we generally ask for tests to be added in a commit before a fix, showing the existing behavior. This would make the commit with the fix show how behavior changed. |
Pull Request Test Coverage Report for Build 21614236997Details
💛 - Coveralls |
Author
|
Thanks, re-ordered the commits and merged in master |
Contributor
|
We actually ask that there be no merge commits and recommend rebasing |
Author
|
done |
epage
reviewed
Feb 4, 2026
| } | ||
|
|
||
| #[test] | ||
| fn boxed_find_case() { |
Contributor
There was a problem hiding this comment.
Does this test pass without the change?'
Every commit should pass tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that test failures still show nicely when using boxing. For example this is the failing test case output:
Showing that previously the debug information was missing when using find_case