Conversation
|
|
||
| def __call__(self) -> str: | ||
| now = datetime.now(timezone.utc) | ||
| return now.strftime("%Y-%m-%d %H:%M:%S UTC") |
There was a problem hiding this comment.
Why do we always want utc? Local timezone or system time would make more sense no?
There was a problem hiding this comment.
In case the report is shared between colleagues in different time zones, I use UTC. The alternative would be to include a note specifying the time zone along with the local time, but using UTC is simpler and easier 😅
There was a problem hiding this comment.
If we add it to the tool store we should at least add an option for that (in the init or as parameter for the agent). Who knows what people are using this tool for in the future, e.g. "Please verify if the clock on this system is correct"...
|
|
||
| def __call__(self) -> str: | ||
| now = datetime.now(timezone.utc) | ||
| return now.strftime("%Y-%m-%d %H:%M:%S UTC") |
There was a problem hiding this comment.
we could make the response for the agent a sentence like "Today is (date) and currently it is (time) (timezone)
| self._max_wait_time = max_wait_time | ||
|
|
||
| def __call__(self, wait_duration: float) -> str: | ||
| if wait_duration < 0.1: |
There was a problem hiding this comment.
why even bother with a minimum wait duration? I think we are fine as long as it is not negative, no?
| "maximum": max_wait_time, | ||
| }, | ||
| }, | ||
| "required": ["max_wait_time", "check_interval"], |
There was a problem hiding this comment.
I would provide a default for check_interval and hence make it not required
| self._max_wait_time = max_wait_time | ||
|
|
||
| def __call__(self, max_wait_time: float, check_interval: float) -> str: | ||
| if max_wait_time < 10: |
There was a problem hiding this comment.
same as above. I think we dont need a minimum wait time
| "maximum": max_wait_time, | ||
| }, | ||
| "check_interval": { | ||
| "type": "number", |
There was a problem hiding this comment.
why not an integer? I dont think we need float precision here
| if max_wait_time > self._max_wait_time: | ||
| msg = f"max_wait_time must not exceed {self._max_wait_time}" | ||
| raise ValueError(msg) | ||
| if check_interval < 1: |
There was a problem hiding this comment.
could be omitted if check_interval is an integer
mlikasam-askui
force-pushed
the
feat/add-wait-tool-for-caching-v2
branch
from
667e163 to
9bcb128
Compare
2 participants
No description provided.