Skip to content

Comments

Fix failing E2E tests#377

Open
DonOmalVindula wants to merge 1 commit intoasgardeo:mainfrom
DonOmalVindula:fix-thunder-tests
Open

Fix failing E2E tests#377
DonOmalVindula wants to merge 1 commit intoasgardeo:mainfrom
DonOmalVindula:fix-thunder-tests

Conversation

@DonOmalVindula
Copy link
Contributor

Purpose

This pull request updates the Thunder E2E test setup to improve compatibility and correctness with the Thunder application and OAuth configuration. The main focus is on ensuring the test application supports the correct user types and has a properly configured OAuth callback and issuer. The most important changes are:

Thunder application user type and OAuth configuration:

  • The Thunder application setup now includes both "Customer" and "Person" in the allowed_user_types to ensure admin users (of type "Person") can authenticate successfully. [1] [2]
  • The OAuth token issuer is corrected to use the base URL (e.g., ${PUBLIC_URL}) instead of including /oauth2/token, to match the OIDC discovery issuer. [1] [2]

Database queries and updates:

  • The SQL queries for retrieving and updating application and OAuth configuration are updated to use the correct tables: APPLICATION and APP_OAUTH_INBOUND_CONFIG instead of the previous tables. [1] [2] [3]

Thunder app config patching:

  • Adds logic to patch the Thunder app configuration at test setup time to ensure "Person" is included in allowed_user_types if missing, improving test reliability for admin users.

Embedded Playwright report update:

  • Updates the base64-encoded Playwright report zip in e2e/playwright-report-embedded/index.html to reflect the latest test results or report structure.

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@asgardeo-github-bot
Copy link

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants