Open
Conversation
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the Thunder E2E test setup to improve compatibility and correctness with the Thunder application and OAuth configuration. The main focus is on ensuring the test application supports the correct user types and has a properly configured OAuth callback and issuer. The most important changes are:
Thunder application user type and OAuth configuration:
allowed_user_typesto ensure admin users (of type "Person") can authenticate successfully. [1] [2]issueris corrected to use the base URL (e.g.,${PUBLIC_URL}) instead of including/oauth2/token, to match the OIDC discovery issuer. [1] [2]Database queries and updates:
APPLICATIONandAPP_OAUTH_INBOUND_CONFIGinstead of the previous tables. [1] [2] [3]Thunder app config patching:
allowed_user_typesif missing, improving test reliability for admin users.Embedded Playwright report update:
e2e/playwright-report-embedded/index.htmlto reflect the latest test results or report structure.Related Issues
Related PRs
Checklist
Security checks