Feature: Download only option and Trunk SHA verification fix #78
Feature: Download only option and Trunk SHA verification fix #78HeyMeco wants to merge 3 commits intoarmbian:mainfrom
Conversation
|
Hi @HeyMeco, I like the idea, but as it currently stands, it might be a bit confusing for users. I think it would be more appropriate to add a toggle in the settings. The download option should also be placed in something separate rather than directly within the device selector, which in my opinion doesn't quite fit—users should be selecting their device there, not downloading images. Of course, it doesn't make sense to add another box on the homepage, but if you have any ideas on where to place that download button in a way that's also aesthetically pleasing, please let me know. In the meantime, if I come up with any ideas, I'll share them here. Thank you for your contribution to the project! |
Can you show me examples where it actually fails? |
I think we need to harden this on CI side so that it won't happen that images are without signatures / SHA artifacts. I have addressed this problem last week and it should be o.k. Only nightly / community images are served via GH so relying on API here, well, ok, but not solving for all. For "download only" in case there is no device to flash. I don't know - i would enable this if developer mode is enabled. IMO normal user should be limited here: "if you don't have a device to flash -> stop & insert device to flash." |
bb9e983 to
a0e7add
Compare
Description
This PR does two things:
Add option to only download the selected image to disk
Fix SHA verification for armbian/os trunk images on GitHub by utilising the GitHub API which offers SHA of the artifact