fix: Handle Wasm ValueTypes returned by imports#141
Draft
blaine-arcjet wants to merge 12 commits intomainfrom
Draft
fix: Handle Wasm ValueTypes returned by imports#141blaine-arcjet wants to merge 12 commits intomainfrom
blaine-arcjet wants to merge 12 commits intomainfrom
Conversation
blaine-arcjet
force-pushed
the
phated/host-import-return-value
branch
from
6ab6e43 to
1d1a789
Compare
blaine-arcjet
force-pushed
the
phated/host-import-return-value
branch
from
5b3a384 to
4c7e1ce
Compare
blaine-arcjet
changed the title
blaine-arcjet
changed the title
wooorm-arcjet
approved these changes
Jan 5, 2026
blaine-arcjet
force-pushed
the
phated/host-import-return-value
branch
from
4c7e1ce to
538bb51
Compare
Contributor
Author
|
This caused some other problems in codegen so I'm drafting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks Wasm imports to build functions with explicit Wasm ValueTypes based on the Wasm signature provided by the WIT tooling. This requires that we use the
stackprovided by Wazero but that makes using the variousapi.Decode*andapi.Encode*functions work correctly on Wasm imports.I believe this resolves some issues introduced by my changes in #96