This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Conversation
t-kelly
approved these changes
Feb 27, 2025
Contributor
t-kelly
left a comment
t-kelly
left a comment
There was a problem hiding this comment.
Thought I had some proposed changes but after reading further you covered them. Anything you want particular attention with?
Comment on lines
+73
to
+76
| [Flags.FORMAT]: OclifFlags.boolean({ | ||
| default: false, | ||
| description: 'Format locale files by sorting keys alphabetically', | ||
| }), |
Contributor
There was a problem hiding this comment.
If this defaults to false, in what order are new locales keys added?
Contributor
Author
There was a problem hiding this comment.
Good question. With format as false, the order corresponds to the sequence in which they appear in the Liquid files. Small caveat though: these new keys aren't reordered amongst the existing keys. They're added at the end of whatever object they're contained in.
Contributor
Author
🙅🏻 Was mostly looking for feedback about the command and its flags. Other than that, a quick scan is enough for me. |
chrisberthe
force-pushed
the
add-locale-command
branch
from
3d7424d to
720a2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.