feat: GPU-accelerated SVD and quaternion conversion for ~4x speedup#72
Open
Mozoloa wants to merge 1 commit intoapple:mainfrom
Open
feat: GPU-accelerated SVD and quaternion conversion for ~4x speedup#72Mozoloa wants to merge 1 commit intoapple:mainfrom
Mozoloa wants to merge 1 commit intoapple:mainfrom
Conversation
This PR adds optional GPU acceleration to the covariance matrix decomposition and rotation-to-quaternion conversion, providing significant performance improvements for CUDA users while maintaining backward compatibility. ## Changes ### `linalg.py` - Add `use_gpu` parameter to `quaternions_from_rotation_matrices()` (default: True) - Add pure PyTorch GPU implementation using Shepperd's method - Original scipy CPU implementation preserved as fallback - ~300x faster for large batches (2M+ gaussians) ### `gaussians.py` - Add `use_gpu` parameter to `decompose_covariance_matrices()` (default: True) - GPU path: SVD on GPU + vectorized reflection correction - CPU path: original float64 behavior preserved for maximum precision - Automatic fallback to CPU if GPU SVD fails ## Performance Tested on RTX 4090 with ~700k gaussians per frame: - Before: ~4.0s per frame (3s quaternion conversion on CPU) - After: ~1.0s per frame - **4x overall speedup** The bottleneck was `scipy.spatial.transform.Rotation.from_matrix()` which requires CPU transfer and numpy conversion. The new GPU implementation stays entirely on device. ## Backward Compatibility - Default behavior unchanged for CPU tensors - Set `use_gpu=False` to force original CPU behavior - API is fully backward compatible (new parameter has default value)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optional GPU acceleration to the covariance matrix decomposition and rotation-to-quaternion conversion, providing significant performance improvements for CUDA users while maintaining backward compatibility.
Changes
linalg.pyuse_gpuparameter toquaternions_from_rotation_matrices()(default: True)gaussians.pyuse_gpuparameter todecompose_covariance_matrices()(default: True)Performance
Tested on RTX 4090 with ~700k gaussians per frame:
The bottleneck was
scipy.spatial.transform.Rotation.from_matrix()which requires CPU transfer and numpy conversion. The new GPU implementation stays entirely on device.Backward Compatibility
use_gpu=Falseto force original CPU behavior