Fix inference crash and dark rendering output#19
Open
nandometzger wants to merge 2 commits intoapple:mainfrom
Open
Fix inference crash and dark rendering output#19nandometzger wants to merge 2 commits intoapple:mainfrom
nandometzger wants to merge 2 commits intoapple:mainfrom
Conversation
- Fixed TypeError in load_ply by converting numpy array to tensor before calling sRGB2linearRGB - Fixed dark rendering issue by ensuring sRGB conversion is applied when input/output is sRGB (even if internal state is linear)
domiverse
reviewed
Dec 20, 2025
| # Colorspace conversion. | ||
| if self.color_space == "sRGB": | ||
| pass | ||
| rendered_color = cs_utils.linearRGB2sRGB(rendered_color) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My testing file uses sRGB

I attach it here so you can reproduce the problem
Error message for the original code: