(fix) Do not longer evaluate params at build time.#40
Merged
Conversation
… to end test data. Update end to end test to run the built impact model.
…en runs. Add two tests to detect unknown parameters in default values.
m-prl
added a commit
that referenced
this pull request
Oct 16, 2025
* (fix) Do not longer evaluate params at build time. Fix sample and end to end test data. Update end to end test to run the built impact model. * (chore) Bump apparun requirement version * (fix) Use approx instead of equal in end to end test * (update) Change parameters declaration to ensure no persistence between runs. Add two tests to detect unknown parameters in default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sample and end to end test data.
Update end to end test to run the built impact model.