This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Open
Conversation
…e value serialization strategy.
…o link to new SDK locations.
…o disable emails.
…ivation with confirmation requirements.
…grid * 'master' of https://git-wip-us.apache.org/repos/asf/usergrid: (50 commits) Fix reactivateTest and handle re-activation differently from auto-activation with confirmation requirements. Fix issue with admin user confirmation flag not working when trying to disable emails. Moving older SDKs to a difference location and updating main README to link to new SDK locations. Removing the old Java SDK. Moving the Android SDK to https://github.com/apache/usergrid-android Moving the .NET SDK to https://github.com/apache/usergrid-dotnet Moving the Java SDK to https://github.com/apache/usergrid-java Moving the Javascript SDK to https://github.com/apache/usergrid-javascript. Moving the Node.js SDK to https://github.com/apache/usergrid-nodejs. Moving Python SDK to https://github.com/apache/usergrid-python Fix UniqueValueManager tool to work with datastax driver in the unique value serialization strategy. Moving Swift SDK to https://github.com/apache/usergrid-swift. Update test for collection level authoritative region setting. Rename the cluster authoritative region parameters/methods to be more specific. Set non-clustered unique value verification loading back to the non-consistent read consistency level. Use StringUtils.isEmpty() to determine if region is not set. Move shard logging statement to TRACE level. Don't shut down full actor system when the JVM exists ( this affects actors running on other hosts ). fix duplicate user test to use random usernames in case DB cleanup not done correctly Allow GET /management/me with local UG tokens when External SSO is enabled. ...
… passed in Authorization header.
… integration into Usergrid.
…operly downs nodes that are restarted but still ok on the network. Don't load all orgs when validating sysadmin creds.
…st like the sysadmin tokens.
…dled more appropriately, allowing access to all parts of the system.
…ided ( you are allowed to create new admin users with just an email and it will invoke a reset password flow).
…eries and email addresses. See: USERGRID-29 USERGRID-1041 USERGRID-1117 USERGRID-1338
…om the database. Added tests to validate
…s the in memory impl causes duplicate messgae processing quite often at the moment. - includes making all the tests work without in-memory queue fronting the database queue which really means adding some more delay in tests - the tests now are actually faster now because the original refreshIndex() created and queried random entities which took longer in most cases - uncommented the checkReceipts function in Notification tests as these are now passing, with an added fix for duplicate receipt creation - some logging updates in the distributed database queueing impl (Qakka) - increased the default take to 500 from the queue when DISTRIBUTED database queueing is configured ( which is the default now ) - Notifications Queue Listener thread names have a random identifier in included - reduced the DISTRIBUTED database queueing default long poll to 1 second from 5 seconds
…on entity create/update.
…e BinaryStore implementation to follow a Factory pattern.
1. Add workers that move messages from dead letter queues back to the indexing and utility queues. 2. Change ERROR for DuplicateUniquePropertyExistsException to INFO. This happens when someone tries to create an entity with the same unique value as another entity, which is not an error that should be logged. 3. Add better logging when cluster region or region list has an invalid region.
…rename the package for TokenServiceImpl to impl from cassandra.
…value. Add trace logging to TokenSerializationImpl. Fix issue with push notifications where the InactiveDeviceManager was making a duplicate (yet incorrect) query for devices.
…ation map. Also, throw exceptions early.
…s never received after a configurable timeout (15 minutes currently). 2. Log messages as they are moved from the dead letter queue back to the originating queue. Also log messages that are in dead letter queue and can't be moved to originating queue for some reason.
|
@michaelarusso @mdunker Is this going to be merged any time soon? |
rodsimpson
reviewed
Aug 28, 2018
Contributor
rodsimpson
left a comment
rodsimpson
left a comment
There was a problem hiding this comment.
Sorry for taking so long to review - everything looks good except for some lingering references to facebook
|
|
||
|
|
||
| /** | ||
| * Provider implementation for sign-in-as with facebook |
Contributor
There was a problem hiding this comment.
Comment references facebook (instead of google)
| String user_picture = (String) google_user.get("picture"); | ||
|
|
||
| if (logger.isDebugEnabled()) { | ||
| logger.debug("FacebookProvider.createOrAuthenticate: {}", JsonUtils.mapToFormattedJsonString(google_user)); |
Contributor
There was a problem hiding this comment.
Lots of facebook references here
Member
|
@suntehnik can you fix the copy-paste errors (e.g. references to facebook and author annotations)? Once you do this, I can re-review and merge. |
|
Can we merge this now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Google as OAuth provider. Basically it's adopted copy of FacebookProvider with minor changes.