Fix CI fuzz job #12835
Fix CI fuzz job #12835
Conversation
Disable testing during the build process for both shared and static libraries.
Updated CIFuzz workflow to use the latest actions from Google OSS-Fuzz.
Updated the BoringSSL checkout commit and modified CMake flags for building shared and static libraries.
Add symbolic links for libswoc shared libraries
There was a problem hiding this comment.
Pull request overview
This PR addresses failures in the CI fuzz job by updating various build dependencies and configurations.
Changes:
- Updated Go version from 1.24.1 to 1.24.12 and BoringSSL git commit hash
- Added additional cmake compiler flags and pthread configuration for BoringSSL builds
- Migrated from Python 2 to Python 3 dependencies and added libpsl-dev, plus added symlinks for libswoc library
- Updated CI runner from ubuntu-latest to ubuntu-24.04
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/build_boringssl_h3_tools.sh | Updates Go version, BoringSSL commit, and cmake build configuration with additional compiler flags and pthread settings |
| tests/fuzzing/oss-fuzz.sh | Migrates from Python 2 to Python 3, adds libpsl-dev dependency, and creates symlinks for libswoc shared library |
| .github/workflows/cifuzz.yml | Updates CI runner to explicitly use Ubuntu 24.04 instead of ubuntu-latest |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/fuzzing/oss-fuzz.sh
Outdated
| ln -sf $OUT/lib/libswoc.so.1.5.15 libswoc.so.1 | ||
| ln -sf $OUT/lib/libswoc.so.1.5.15 libswoc.so |
There was a problem hiding this comment.
The symlink targets are missing the destination directory. These commands will create symlinks in the current working directory (build/) rather than in $OUT/lib/ where they should be. The commands should be: ln -sf $OUT/lib/libswoc.so.1.5.15 $OUT/lib/libswoc.so.1 and ln -sf $OUT/lib/libswoc.so.1.5.15 $OUT/lib/libswoc.so, or alternatively change to $OUT/lib/ before creating the symlinks.
| ln -sf $OUT/lib/libswoc.so.1.5.15 libswoc.so.1 | |
| ln -sf $OUT/lib/libswoc.so.1.5.15 libswoc.so | |
| ln -sf $OUT/lib/libswoc.so.1.5.15 $OUT/lib/libswoc.so.1 | |
| ln -sf $OUT/lib/libswoc.so.1.5.15 $OUT/lib/libswoc.so |
Change directory to $OUT/lib before creating symlinks for libswoc.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
The fuzz job is currently failing. This is part of the fix.