Make 9.2.x buildable on macOS 26 #12834
Open
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
commented
Jan 28, 2026
| #include "tscore/ink_config.h" | ||
|
|
||
| #ifdef HAVE_SYS_ENDIAN_H | ||
| #if !defined(darwin) |
Member
Author
There was a problem hiding this comment.
Old versions of macOS didn't have be64toh and the other functions, but now those are defined on endian.h, and those cause errors due to duplication.
I could add a check for the availability of those functions, but this small change is enough. We don't have this issue on newer codebase.
maskit
commented
Jan 28, 2026
|
|
||
| AC_MSG_CHECKING([for C compiler version]) | ||
| # Capture the output of the compiler version command | ||
| ac_cv_c_compiler_version=`${CC} --version 2>&1 | grep "Apple clang version" | head -n 1 | awk '{print $4}' | cut -d'.' -f1` |
Member
Author
There was a problem hiding this comment.
This is hacky and only works for Apple Clang 17, but I don't think we will need to maintain it for a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
-Wno-cast-function-type-mismatchisn't great, but I don't think we should make changes that this check may find, on 9.2.x.