Add isIndexEncrypted flag and encryption listener.#128
Open
bruno-roustant wants to merge 1 commit intoapache:mainfrom
Open
Add isIndexEncrypted flag and encryption listener.#128bruno-roustant wants to merge 1 commit intoapache:mainfrom
bruno-roustant wants to merge 1 commit intoapache:mainfrom
Conversation
dsmiley
reviewed
Oct 31, 2025
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
Just a general comment: It's pretty confusing/difficult (impacting ease of code review and observability -- that you are trying to add here) to have a Directory, named EncryptionDirectory no less, that can flip flop between being encrypted and not encrypted. IMO it'd be much easier for an EncryptionDirectory to be, well, encrypted -- period. Going from cleartext to encrypted could be done via backup/restore or via maybe even through the process of adding replicas (and removing the old), provided these go via the Directory. The DirectoryFactory would have to pick what it's a factory of when initializing a new directory. But that's not how things are...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new flag EncryptionDirectoryFactory.isIndexEnabled() is set when the EncryptionDirectory opens an output/input stream that requires encryption. For example, this may allow some custom code to log whether the index is encrypted.