[Draft] Upgrade servicecomb version to 3.x , jdk version to 17 and improve readme docs
#144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- basic - basic-tomcat - bmi - java-chassis-deployment-samples - java-chassis-interoprability - porter - ServiceComb-SpringMVC
- apm-agent - auth-sample - codefirst-sample - common-schema - config-apollo-sample - custom-handler-sample - jaxrs-sample - local-service-registry - metrics-extend-healthcheck - pojo-sample - springmvc-sample - trust-sample - use-log4j2-sample
Added instructions and links for downloading Local-CSE as an alternative to local-service-center in both English and Chinese sections of the README.
Corrected the indentation of the 'registry' section and added a 'sc' key under 'registry' in microservice.yaml to ensure proper configuration structure.
Updated instructions in both English and Chinese sections to clarify that the file ID is a randomly generated number and only the admin account can delete files. Improved formatting for usernames, passwords, and file IDs.
- Standardized header styles and adjusted indentation for clarity. - Updated instructions for starting services, verifying outputs, and running examples using Maven and IDE. - Enhanced descriptions for configurations in `microservice.yaml`. - Added missing steps and clarified verification instructions for the `auth-sample`. - Ensured message formatting for all examples is consistent and easier to read.
- Updated `README.md` for improved formatting and clarity. - Adjusted dependency setup in `pom.xml` for both client and server to use `solution-basic`. - Fixed type mismatch in `LocalRegistryClient` to align with proper data handling using `Integer`.
- Replaced manual resource management with `try-with-resources` in `MySqlHealthChecker`. - Enhanced clarity and consistency in `README.md`, including formatting updates and corrected URLs for health checks.
- Updated header styles for better consistency and readability. - Adjusted indentation and spacing across sections. - Enhanced clarity in service start-up instructions and verification steps.
- Updated header styles for consistency. - Adjusted indentation and spacing for better readability. - Clarified service start-up and verification instructions. - Improved output format for verification examples.
- Standardized header styles and improved formatting for better readability. - Added detailed instructions for provider, consumer, and hacker service setup. - Introduced verification steps with expected outputs for all services. - Clarified configuration usage in `microservice.yaml`. Enhance README structure and clarity for trust-sample - Standardized header styles and improved formatting for better readability. - Added detailed instructions for provider, consumer, and hacker service setup. - Introduced verification steps with expected outputs for all services. - Clarified configuration usage in `microservice.yaml`.
- Introduced a new sample demonstrating the use of Log4j2 as the logging framework in Java Chassis microservices. - Detailed setup instructions in the README, including Log4j2 configuration and verification steps. - Added `@GetMapping` annotation for `/hello` endpoint in `HelloImpl`. - Updated `pom.xml` to include necessary Log4j2 dependency and simplified dependency setup.
This commit refactors the custom handler sample to use filters instead of handlers for custom processing. This aligns with the latest Java Chassis 3.x architecture and provides enhanced support for asynchronous processing.
Introduces the APM Agent sample for ServiceComb, detailing its features, integration steps, output format, extension points, and references. Provides comprehensive instructions for building, running, and customizing the agent for performance monitoring in microservice applications.
Expanded the list of supported BootListener and EventBus event types in the APM agent README. Added new event types and clarified base event classes to provide more comprehensive documentation for developers integrating with the event system.
Updated timeline comments and ordering in ConsumerOutputGenerator and ProducerOutputGenerator for clarity and correctness. Removed redundant timeline output in HeaderOutputGenerator and super.generate call in EdgeOutputGenerator. Deleted the META-INF/services/org.apache.servicecomb.core.BootListener SPI registration file, indicating ApmBootListener is no longer registered as a BootListener.
Enhanced the README with detailed build and deployment instructions for running the sample in an external Tomcat. Updated pom.xml to use Java 17 and explicitly override SLF4J to version 2.0.16, ensuring compatibility and consistency.
Introduces a new sample project demonstrating how to integrate ServiceComb microservices into a traditional Java Web application deployed on external Tomcat. Adds legacy Servlet and Filter, JSP support, and updates pom.xml for Java 17, SLF4J 2.x, and ServiceComb 3.x compatibility. Updates web.xml for legacy component configuration and provides documentation in README.md.
Refactored the metrics-write-file sample to support ServiceComb 3.x and Micrometer, replacing Spectator and Java SPI with Spring Boot AutoConfiguration. Updated dependencies, removed SPI registration, added auto-configuration class, and revised CloudEyeFilePublisher for Micrometer and Spring integration. Enhanced README with detailed usage, migration notes, and troubleshooting.
Enhanced log4j2.xml for consumer, gateway, and provider modules by adding rolling file appenders for access, metrics, and slow logs. Introduced log file path properties and updated console log patterns for improved log management and organization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associate with issue: #143
Main changes:
servicecombversion to3.3.02.xunnecessary propertiesNot changed:
java-chassis-benchmarkjava-chassis-integration-testsDetailed changes:
basicservicecomband jdk versionbasic-tomcatservicecomband jdk versionlog4j2.xmlbmiservicecomband jdk versionjava-chassis-deployment-samplesspring-boot-external-tomcatservicecomband jdk versionwar-external-tomcatservicecomband jdk versionServiceComb 3.x: ServiceComb3.xno longer supports the2.xstyleRestServletContextListenerbootstrap and instead relies on Spring Boot auto-configuration (viajava-chassis-spring-boot-starter-servletandSpringBootServletInitializer), while keeping traditionalweb.xmlcomponents (Servlet/Filter/JSP) to demonstrate legacy coexistence and to differentiate fromspring-boot-external-tomcatSLF4J 2.xand exclude competing transitive SLF4J/logging artifacts)java-chassis-interoprabilityservicecomb,spring-cloud-huaweiand jdk versionporterservicecomband jdk versionsessiondId(inconsistent naming may be compatible, but it looks strange whenever one sees it, so it should be fixed as well)ServiceComb-SpringMVCservicecomband jdk versionservicecombandlog4j2versionjava-chassis-sampleschanges:[Big change]
apm-agentservicecomband jdk versionservicecomb 3.x: registerApmBootListeneras a Spring Bean viaApplicationContextInitializer(set bycontext.initializer.classesinpremain) becauseservicecombloadsBootListenervia Spring DI (@Autowired) instead of Java SPI/ServiceLoaderprovider-sendstage), to avoid repeated or misleading metricsauth-sampleservicecomband jdk versioncodefirst-sampleservicecomband jdk versionsolution-basicinstead of specifically importing subpackagescommon-schemaconfig-apollo-sampleservicecomband jdk version[Big change]
custom-handler-sampleservicecomband jdk versionjaxrs-sampleservicecomband jdk versionlocal-service-registryservicecomband jdk versionmetrics-extend-healthcheckservicecomband jdk version[Big change]
metrics-write-file-sampleservicecomband jdk versionservicecomb 3.x: migrate from Spectator-based metrics to Micrometer (MeterRegistry) and keep collecting metrics via EventBusPolledEventMETA-INF/services) to Spring Boot AutoConfiguration (META-INF/spring/...AutoConfiguration.imports) and addservicecomb.metrics.write-file.enabledfor conditional enable/disablelog4j2/logbackconfigs) so external systems can collect metrics by reading filespojo-sampleservicecomband jdk versionspringmvc-sampleservicecomband jdk versionCseAsyncRestTemplateto aync RPC referencetrust-sampleservicecomband jdk versionsolution-basicinstead of specifically importing subpackageshandler-publickey-authfeature)use-log4j2-sampleservicecomband jdk version