Update apache licenses + add servlet-api dependency#28
Open
kietly wants to merge 1 commit intoapache:masterfrom
kietly:aws
Open
Update apache licenses + add servlet-api dependency#28kietly wants to merge 1 commit intoapache:masterfrom kietly:aws
kietly wants to merge 1 commit intoapache:masterfrom
kietly:aws
Conversation
Author
|
I switched to develop branch and mvn test failed on rya.web without the servlet-api. I recommended switch to java 8 if there is not an outstanding issue. Ignore the my RAT fixed. |
|
hey i remember there being some contention with this pr, so i didn't pull it in. does anyone have an issue with this pull request anymore? |
Contributor
|
I'd hold off a bit on merging this. It upgrades some dependencies. Wait for the release. |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fixed apache 2.0 license header