JCRVLT-830 check if a subfolder can be removed#416
Draft
Conversation
kwin
requested changes
Feb 26, 2026
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/api/WorkspaceFilter.java
Outdated
Show resolved
Hide resolved
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/api/WorkspaceFilter.java
Show resolved
Hide resolved
kwin
reviewed
Feb 27, 2026
| return false; | ||
| } | ||
| } | ||
| NodeIterator children = node.getNodes(); |
Member
There was a problem hiding this comment.
For performance reason I wouldn't iterate over all properties/children from the repo but just over all filter rules. That is enough to determine the outcome and should be way faster....
Contributor
Author
There was a problem hiding this comment.
ok, so you mean, that if the node is not affected, any childnode of it (and their properties) cannot be affected as well?
Member
There was a problem hiding this comment.
A filter without includes/excludes always covers everything below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented some additional checks to prevent the removal of unexpected files.