JCRVLT-821: update max test versions to Oak 1.84.0 and Jackrabbit 2.22.2#388
JCRVLT-821: update max test versions to Oak 1.84.0 and Jackrabbit 2.22.2#388
Conversation
kwin
left a comment
There was a problem hiding this comment.
The idea was that the target-osgi-environment represents some real live distribution not something which one can arbitrarily increase. Please pick a recent AEMaaCS version which already comes with Collections 4.5 and also update all other bundles accordingly.
There was a problem hiding this comment.
In line40 the comment must be changed (was wrong right from the beginning), it used to reflect the bundles provided by some AEMaaCS version.
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-collections4</artifactId> | ||
| <version>4.4</version> | ||
| <version>4.5.0</version> |
There was a problem hiding this comment.
Why is this necessary in this context? IMHO the max versions are never used to calculate import package version ranges....
There was a problem hiding this comment.
Sorry, indeed we are embedding the max versions of some JR2 artifacts even in the OSGi bundles. Should we rethink this? Currently those are
jackrabbit-filevault/vault-core/bnd.bnd
Line 20 in 4806680
There was a problem hiding this comment.
The requirement comes from the fact that otherwise ITs fails because they need 4.5.0.
|
See bb117c2 But with these changes, I now see: |
No description provided.