Add fallback for log truncation issue in Delta source#782
Draft
vinishjail97 wants to merge 1 commit intomainfrom
Draft
Add fallback for log truncation issue in Delta source#782vinishjail97 wants to merge 1 commit intomainfrom
vinishjail97 wants to merge 1 commit intomainfrom
Conversation
4 tasks
brishi19791
reviewed
Feb 3, 2026
| return deltaCommitInstant.equals(instant) || deltaCommitInstant.isBefore(instant); | ||
| try { | ||
| DeltaHistoryManager.Commit deltaCommitAtOrBeforeInstant = | ||
| deltaLog.history().getActiveCommitAtTime(Timestamp.from(instant), true, false, true); |
Contributor
There was a problem hiding this comment.
3rd #argument seems to be "mustBeRecreatable" and is false. if we just make this to true wont it be enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
(For example: This pull request implements the sync for delta format.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)