IGNITE-27873 Fix flaky IgniteCacheQueryStopOnCancelOrTimeoutDistributedJoinSelfTest related tests#12749
Open
zstan wants to merge 1 commit intoapache:masterfrom
Open
IGNITE-27873 Fix flaky IgniteCacheQueryStopOnCancelOrTimeoutDistributedJoinSelfTest related tests#12749zstan wants to merge 1 commit intoapache:masterfrom
zstan wants to merge 1 commit intoapache:masterfrom
Conversation
zstan
force-pushed
the
ignite-27873
branch
2 times, most recently
from
5f9ba6b to
aa4d6ed
Compare
…edJoinSelfTest related tests
|
| private void testQueryCancel(Ignite ignite, String cacheName, String sql, int timeoutUnits, TimeUnit timeUnit, | ||
| boolean timeout, boolean checkCanceled) throws Exception { | ||
| SqlFieldsQuery qry = new SqlFieldsQuery(sql).setDistributedJoins(true); | ||
| SqlFieldsQuery qry = new SqlFieldsQuery(sql).setDistributedJoins(true);; |
Comment on lines
+110
to
+113
| int resSize = 0; | ||
| for (List<?> ignored1 : cursor) { | ||
| ++resSize; | ||
| } |
Contributor
There was a problem hiding this comment.
int resSize = F.size(cursor.iterator());?
Comment on lines
138
to
139
| ConcurrentMap<UUID, ?> map = U.field(((IgniteH2Indexing)U.field((GridProcessor)U.field( | ||
| grid.context(), "qryProc"), "idx")).mapQueryExecutor(), "qryRess"); |
Contributor
There was a problem hiding this comment.
Let's fix this mess too:
ConcurrentMap<UUID, ?> map = U.field(
((IgniteH2Indexing)grid(0).context().query().getIndexing()).mapQueryExecutor(), "qryRess");
| try (QueryCursor<List<?>> ignored = cursor) { | ||
| cursor.getAll(); | ||
| int resSize = 0; | ||
| for (List<?> ignored1 : cursor) { |
Contributor
There was a problem hiding this comment.
testCancel3 fails sometimes here locally:
org.apache.ignite.IgniteException: The query was cancelled while executing.
at org.apache.ignite.internal.util.lang.GridIteratorAdapter.next(GridIteratorAdapter.java:38)
at org.apache.ignite.internal.processors.query.GridQueryCacheObjectsIterator.next(GridQueryCacheObjectsIterator.java:67)
at org.apache.ignite.internal.processors.query.GridQueryCacheObjectsIterator.next(GridQueryCacheObjectsIterator.java:31)
at org.apache.ignite.internal.processors.cache.QueryCursorImpl$LazyIterator.next(QueryCursorImpl.java:287)
at org.apache.ignite.internal.processors.query.h2.RegisteredQueryCursor$RegisteredIterator.next(RegisteredQueryCursor.java:181)
It happens when query cancelled during fetch (after iterator() call and before all result processed). Exception was wrapped to IgniteException, but CacheException expected.
|
|
||
| /** */ | ||
| private static final int PURCHASE_CNT = 6_000; | ||
| private static final int PURCHASE_CNT = 24_000; |
Contributor
There was a problem hiding this comment.
It still looks fragile. On fast environment we will again face this problem. Maybe use functions to guarantee long time execution (sleep, latch)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.