IGNITE-27845 Use MessageSerializer for CacheContinuousQueryEntry#12744
Open
abashev wants to merge 1 commit intoapache:masterfrom
Open
IGNITE-27845 Use MessageSerializer for CacheContinuousQueryEntry#12744abashev wants to merge 1 commit intoapache:masterfrom
abashev wants to merge 1 commit intoapache:masterfrom
Conversation
abashev
force-pushed
the
feature/IGNITE-27845
branch
2 times, most recently
from
2ef00de to
c0ce88e
Compare
|
shishkovilja
requested changes
Feb 19, 2026
| * | ||
| */ | ||
| public class IgniteCacheContinuousQueryImmutableEntryTest extends GridCommonAbstractTest { | ||
| /** Message factory. */ |
Contributor
There was a problem hiding this comment.
Why is it moved here? Why protected? Are there any significant reason for this?
| @Test | ||
| public void testCacheContinuousQueryEntrySerialization() { | ||
| CacheContinuousQueryEntry e0 = new CacheContinuousQueryEntry( | ||
| var srcMsg = new CacheContinuousQueryEntry( |
| } | ||
| /** Cache name. */ | ||
| @Order(0) | ||
| private int cacheId; |
Contributor
There was a problem hiding this comment.
Why moved? Purpose of change?
|
|
||
| /** */ | ||
| @Order(2) | ||
| private long filteredCnt; |
|
|
||
| /** Flags. */ | ||
| @Order(3) | ||
| private byte flags; |
| private long filteredCnt; | ||
| /** Update counter. */ | ||
| @Order(9) | ||
| private long updateCntr; |
| // Skip write class header. | ||
| writer.onHeaderWritten(); | ||
| e0.writeTo(buf, writer); | ||
| var resMsg = doMarshalUnmarshal(srcMsg); |
Contributor
There was a problem hiding this comment.
Can we keep old logic, except for usage of deprecated methods? Just replace logic, where serializer is necessry for test to work correctly.
Contributor
|
@abashev , also there are many duplications of getters and setters in message class. |
abashev
force-pushed
the
feature/IGNITE-27845
branch
from
4549244 to
46c1e7e
Compare
abashev
force-pushed
the
feature/IGNITE-27845
branch
from
46c1e7e to
0a58a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.