IGNITE-27836 Fix documentation for QuerySqlTableFunction#12743
IGNITE-27836 Fix documentation for QuerySqlTableFunction#12743zstan wants to merge 8 commits intoapache:masterfrom
Conversation
modules/core/src/main/java/org/apache/ignite/cache/query/annotations/QuerySqlTableFunction.java
Show resolved
Hide resolved
| assertQuery("select TYPEOF(?)").withParams(1L).returns("BIGINT").check(); | ||
| assertQuery("select ? + ?").withParams(1, 2).returns(3).check(); | ||
| assertThrows("select PLUS(?, ?)", SqlValidatorException.class, "No match found for function signature", 1, 2); | ||
| assertQuery("SELECT UNIX_SECONDS(TIMESTAMP '2021-01-01 00:00:00')").returns(1609459200L).check(); |
There was a problem hiding this comment.
I don't think these changes are necessary to this ticket, it's at your discretion, of course.
There was a problem hiding this comment.
why not to align all these stuff here ?
There was a problem hiding this comment.
In my opinion, these changes are redundant within the scope of the documentation ticket and are not related to this issue.
From my experience, when looking at the diff, it's better to see the ticket where the change occurred and made sense, rather than having to delve into an unrelated PR and look through everything there to figure it out.
In my opinion, it's better not to do this in this ticket.
Refactoring and other issues should be a separate ticket.
I'm not insisting it's up to you.
modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java
Outdated
Show resolved
Hide resolved
|
|
|
||
| assertTrue(rs.next()); | ||
| assertEquals("row2", rs.getString(1)); | ||
| } |
There was a problem hiding this comment.
assertFalse(rs.next());? Up to you.
3 participants
https://issues.apache.org/jira/browse/IGNITE-27836
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.