Core: Fix compute_table_stats failures with concurrent writes #15148
+240
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramaticlly
reviewed
Jan 26, 2026
Contributor
dramaticlly
left a comment
dramaticlly
left a comment
There was a problem hiding this comment.
I think we shall add commit retry like other PendingUpdate implementation class, RemoveSnapshots is a good example. But we can probably simplify the unit test a bit
|
|
||
| // Skip if no changes | ||
| if (base == newMetadata) { | ||
| LOG.info("No statistics changes to commit, skipping"); |
Contributor
There was a problem hiding this comment.
I think debug shall be sufficient here or we can remove it entirely.
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class SetStatistics implements UpdateStatistics { | ||
| private static final Logger LOG = LoggerFactory.getLogger(SetStatistics.class); |
Contributor
There was a problem hiding this comment.
nit: new line after to separate with non-static
| * <p>Tests that SetStatistics properly handles concurrent modifications using retry mechanism. | ||
| */ | ||
| @ExtendWith(ParameterizedTestExtension.class) | ||
| public class TestSetStatisticsConcurrency extends TestBase { |
Contributor
There was a problem hiding this comment.
do we need a new unit test ? I think we might just bring those to TestSetStatistics.java. From what I can tell, the comment in unit test is uncommon, usually assertion with assertThat().as($comments) is self-explanatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute_table_stats fails with CommitFailedException when concurrent writes modify table metadata during statistics computation.