HBASE-29825: Incremental backup is failing due to incorrect timezone

[kgeisz]

https://issues.apache.org/jira/browse/HBASE-29825

HBASE-29656 introduced an issue where continuous incremental backups would fail when run at certain times of the day. This occurred because BackupUtils.getValidWalDirs() was not using the UTC time zone when checking if a day's WAL files overlap with the required time range. If the user ran a continuous incremental backup when it was "today" in local time but "tomorrow" in UTC time (such as 4:00 PM PST), then the list of valid WAL directories would incorrectly be empty.

This pull request fixes the issue by setting the time zone to UTC in BackupUtils.getValidWalDirs(). It also adds some unit test cases for getValidWalDirs(). I have confirmed this fix works with IntegrationTestContinuousBackupRestore in the HBASE-29164 branch.

[taklwu]

LGTM

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ HBASE-28957_rebased Compile Tests _
+1 💚	mvninstall	3m 37s		HBASE-28957_rebased passed
+1 💚	compile	0m 40s		HBASE-28957_rebased passed
+1 💚	checkstyle	0m 14s		HBASE-28957_rebased passed
+1 💚	spotbugs	0m 35s		HBASE-28957_rebased passed
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	0m 34s		the patch passed
+1 💚	javac	0m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 12s		the patch passed
+1 💚	spotbugs	0m 36s		the patch passed
+1 💚	hadoopcheck	12m 12s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 48s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		32m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7683/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7683
JIRA Issue	HBASE-29825
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux b794681bf88f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28957_rebased / ebade8b
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7683/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ HBASE-28957_rebased Compile Tests _
+1 💚	mvninstall	3m 34s		HBASE-28957_rebased passed
+1 💚	compile	0m 20s		HBASE-28957_rebased passed
+1 💚	javadoc	0m 15s		HBASE-28957_rebased passed
+1 💚	shadedjars	6m 16s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	0m 20s		the patch passed
+1 💚	javac	0m 20s		the patch passed
+1 💚	javadoc	0m 13s		the patch passed
+1 💚	shadedjars	6m 7s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	19m 7s		hbase-backup in the patch passed.
		41m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7683/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7683
JIRA Issue	HBASE-29825
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux aec3549a1561 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28957_rebased / ebade8b
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7683/2/testReport/
Max. process+thread count	3652 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7683/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.