This repository was archived by the owner on Oct 30, 2023. It is now read-only.
Prefers OutputStream instead of FileOutputStream to improve performance.#79
Open
reudismam wants to merge 1 commit intoapache:trunkfrom
Open
Prefers OutputStream instead of FileOutputStream to improve performance.#79reudismam wants to merge 1 commit intoapache:trunkfrom
reudismam wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
|
Can you comment on how this improves performance? |
Author
|
FileInputStream and FileOutputStream override the finalize method. As a result, their objects are only cleaned when the garbage collector performs a sweep. Since Java 7, programmers can use Files.newInputStream and Files.newOutputStream instead of FileInputStream and FileOutputStream to improve performance. finalize method is deprecated in Java 9+. |
dlogothetis
approved these changes
Nov 7, 2018
dlogothetis
reviewed
Nov 7, 2018
Contributor
dlogothetis
left a comment
dlogothetis
left a comment
There was a problem hiding this comment.
@reudismam, how did you test this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.