-
Notifications
You must be signed in to change notification settings - Fork 491
[helm] Allow templating listeners (internal, client) from values #2460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
affo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Multiple comments added.
I would also add, that it would also be nice to also configure the security protocol map as part of this PR.
As we would allow to template listeners, one can decide for the port, as well as the security protocol.
|
Thanks @affo, I have addressed your findings. I will introduce the external access support in the follow up PR. For the security map, let's discuss it once we have PR for enabling security (e.g, SASL) protocol in the helm charts 🤝 |
affo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Good to go for me 🤝
For the security protocol, @morazow can you please follow up with a PR before the external connection?
Ideally any external connection should specify some security criteria 🤝
Purpose
Linked issue: close #2459
Brief change log
Adds templating for listeners in the values file
Tests
NA
API and Format
NA
Documentation
Updated for listeners configuration options.