[CALCITE-7356] The MARK JOIN generated by TopDownGeneralDecorrelator needs to be adapted to RelFieldTrimmer #4752
+75
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiedeyantu
commented
Jan 17, 2026
| | 170 | 30 | Theodore | 11500.00 | 250 | true | | ||
| | 200 | 20 | Eric | 8000.00 | 500 | false | | ||
| +-------+--------+-----------+----------+------------+--------+ | ||
| (6 rows) |
Member
Author
There was a problem hiding this comment.
The result is checked using pgsql. link is here.
xiedeyantu
force-pushed
the
CALCITE-7356
branch
from
929ca6f to
c64d260
Compare
silundong
approved these changes
Jan 19, 2026
xiedeyantu
added
the
LGTM-will-merge-soon
…needs to be adapted to RelFieldTrimmer
xiedeyantu
force-pushed
the
CALCITE-7356
branch
from
6097536 to
928f301
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CALCITE-7356