[CALCITE-7279] Resolve ClickHouse identifier resolution error by aliasing nested JOIN projections #4692
+269
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
reviewed
Dec 17, 2025
core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
xiedeyantu
reviewed
Dec 18, 2025
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
Member
|
Tip: The commit message, Jira title and PR title should be consistent. I think the commit message title is fine. PR title may lose something. |
xuzifu666
reviewed
Dec 18, 2025
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
Dwrite
changed the title
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java
Outdated
Show resolved
Hide resolved
Dwrite
changed the title
mihaibudiu
reviewed
Dec 22, 2025
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
mihaibudiu
reviewed
Dec 22, 2025
core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java
Outdated
Show resolved
Hide resolved
Dwrite
requested review from
dssysolyatin,
mihaibudiu,
xiedeyantu and
xuzifu666
mihaibudiu
requested changes
Jan 6, 2026
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
I will look again when you have removed the spurious changes
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
mihaibudiu
approved these changes
Jan 6, 2026
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
This looks fine, but I still have a few comments that are unaddressed.
Contributor
|
The CI failures seem transient, maybe they will go away if you add a new commit. |
mihaibudiu
added
the
LGTM-will-merge-soon
Dwrite
force-pushed
the
calciate-7279
branch
3 times, most recently
from
a84b411 to
33cd482
Compare
Dwrite
force-pushed
the
calciate-7279
branch
2 times, most recently
from
186e59a to
2c84e5d
Compare
Contributor
|
A bit early to squash commits, you should do that after the PR is accepted. |
mihaibudiu
reviewed
Jan 12, 2026
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
Outdated
Show resolved
Hide resolved
Author
|
mihaibudiu
approved these changes
Jan 13, 2026
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
Lots of people have commented, but if no one else has additional comments, I think this is ready to merge.
Contributor
|
But, of course, now commits can be squashed |
…cit column aliases
Author
|
Thanks everyone. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickHouse does not support standard nested JOIN syntax and has strict scoping rules for identifiers in subqueries. When a JOIN's right side is another JOIN, it must be wrapped in a subquery.
This commit ensures that the ClickHouse dialect:
Wraps nested JOINs in a subquery to satisfy syntax requirements.
Generates explicit column aliases (e.g., AS col_name) for all projected columns within the subquery. This prevents "Unknown Identifier" errors by ensuring internal table qualifiers are flattened and resolvable by the outer query block.
Avoids redundant subquery nesting to maintain optimal SQL structure.