Skip to content

[ARUON #1541] Add work flow for iceberg #1541 #1536 #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guixiaowen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[ARUON #1541] Add work flow for iceberg #1541 #1536 #1936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92797fa
[ARUON #1541] Add work flow for iceberg #1541 #1935
Jan 20, 2026
6bc8687
[ARUON #1541] Add work flow for iceberg #1541 #1935
Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions .github/workflows/iceberg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
#
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title contains a spelling error. "ARUON" should be spelled "AURON" to match the project name used throughout the workflow file (see line 50 "Checkout Auron").

Copilot uses AI. Check for mistakes.
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

name: Iceberg

on:
workflow_dispatch:
push:
branches:
- master
- branch-*
pull_request:
branches:
- master
- branch-*

concurrency:
group: iceberg-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
test-flink:
Copy link
Contributor

@ShreyeshArangath ShreyeshArangath Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test-flink:
test-iceberg:

Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job name is "test-flink" but this workflow is testing Iceberg modules, not Flink. The job name should be updated to accurately reflect what is being tested, such as "test-iceberg" or "test-iceberg-module".

Suggested change
test-flink:
test-iceberg:

Copilot uses AI. Check for mistakes.
name: Test Iceberg ${{ matrix.iceberg }} javaVersion ${{ matrix.javaver }} scalaVersion ${{ matrix.scalaver }}
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
iceberg: [ "1.10.1" ]
javaver: [ "17"]
scalaver: [ "2.12", "2.13"" ]
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a syntax error in the YAML array definition. The line has two double quotes after "2.13" which will cause the workflow to fail parsing. The correct syntax should have only one double quote at the end of the array.

Suggested change
scalaver: [ "2.12", "2.13"" ]
scalaver: [ "2.12", "2.13" ]

Copilot uses AI. Check for mistakes.
module: [ "thirdparty/auron-iceberg" ]
sparkver: [ "spark-3.4", "spark-3.5" ]


steps:
- name: Checkout Auron
uses: actions/checkout@v4
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is using an outdated version of the checkout action. Other similar workflows in the repository (flink.yml, paimon.yml) use actions/checkout@v6, while this workflow uses actions/checkout@v4. For consistency and to use the latest features and security updates, this should be updated to v6.

Suggested change
uses: actions/checkout@v4
uses: actions/checkout@v6

Copilot uses AI. Check for mistakes.

- name: Setup Java and Maven cache
uses: actions/setup-java@v4
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is using an outdated version of the setup-java action. Other similar workflows in the repository (flink.yml, paimon.yml) use actions/setup-java@v5, while this workflow uses actions/setup-java@v4. For consistency and to use the latest features and security updates, this should be updated to v5.

Suggested change
uses: actions/setup-java@v4
uses: actions/setup-java@v5

Copilot uses AI. Check for mistakes.
with:
distribution: 'adopt-hotspot'
java-version: ${{ matrix.javaver }}
cache: 'maven'

- name: Test Iceberg Module
run: ./build/mvn -B test -X -pl ${{ matrix.module }} -am -Pscala-${{ matrix.scalaver }} -Piceberg-${{ matrix.iceberg }} -P${{ matrix.sparkver }} -Prelease
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Maven test command includes the -X flag which enables debug output. This flag is not used in other similar workflows (flink.yml, paimon.yml) in the repository and will produce verbose output that can clutter the CI logs. Unless debug output is specifically needed for troubleshooting, this flag should be removed for consistency with other workflows.

Suggested change
run: ./build/mvn -B test -X -pl ${{ matrix.module }} -am -Pscala-${{ matrix.scalaver }} -Piceberg-${{ matrix.iceberg }} -P${{ matrix.sparkver }} -Prelease
run: ./build/mvn -B test -pl ${{ matrix.module }} -am -Pscala-${{ matrix.scalaver }} -Piceberg-${{ matrix.iceberg }} -P${{ matrix.sparkver }} -Prelease

Copilot uses AI. Check for mistakes.

- name: Upload reports
if: failure()
uses: actions/upload-artifact@v4
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is using an outdated version of the upload-artifact action. Other similar workflows in the repository (flink.yml, paimon.yml) use actions/upload-artifact@v6, while this workflow uses actions/upload-artifact@v4. For consistency and to use the latest features and security updates, this should be updated to v6.

Suggested change
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6

Copilot uses AI. Check for mistakes.
with:
name: ${{ matrix.module }}-test-report
path: ${{ matrix.module }}/target/surefire-reports
Loading