[AURON #1850] Introduce Flink RowData to Arrow conversion #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Flink RowData to Arrow format conversion for Auron-Flink integration. Key components: - FlinkArrowUtils: Type conversion between Flink LogicalType and Arrow types - FlinkArrowWriter: Converts Flink RowData to Arrow VectorSchemaRoot - FlinkArrowFieldWriter: Field-level writers for all supported types - FlinkArrowFFIExporter: Exports Arrow data via FFI for native consumption Supported types: - Primitive: Boolean, TinyInt, SmallInt, Int, BigInt, Float, Double - String/Binary: VarChar, Char, VarBinary, Binary - Temporal: Date, Time, Timestamp, LocalZonedTimestamp - Complex: Array, Map, Row/Struct - Decimal (128-bit)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Flink RowData to Arrow format conversion for the Auron-Flink integration. It introduces new utilities and writers to convert Flink's table data structures to Apache Arrow format, enabling efficient data exchange between Flink and native code via the Arrow C Data Interface.
Changes:
- Added FlinkArrowUtils for type conversion between Flink LogicalType and Arrow types
- Implemented FlinkArrowWriter and FlinkArrowFieldWriter for converting RowData to Arrow vectors
- Added FlinkArrowFFIExporter for asynchronous FFI-based data export with producer-consumer pattern
- Included comprehensive unit tests for all conversion and export functionality
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| FlinkArrowUtils.java | Provides utilities for converting Flink types to Arrow types and creating Arrow schemas |
| FlinkArrowFieldWriter.java | Implements field writers for all supported Flink types with recursive handling for complex types |
| FlinkArrowWriter.java | Main writer class that orchestrates conversion of RowData to VectorSchemaRoot |
| FlinkArrowFFIExporter.java | Asynchronous exporter using double-queue pattern for safe FFI data export |
| FlinkArrowUtilsTest.java | Tests type conversion logic for all supported types |
| FlinkArrowWriterTest.java | Tests data writing for basic, complex, and edge cases |
| FlinkArrowFFIExporterTest.java | Tests FFI export functionality with native library availability checks |
| pom.xml | Adds required Arrow and Flink dependencies |
| .gitignore | Adds IDE/LSP configuration patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...xtension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/FlinkArrowUtils.java
Show resolved
Hide resolved
...ion/auron-flink-runtime/src/test/java/org/apache/auron/flink/arrow/FlinkArrowWriterTest.java
Outdated
Show resolved
Hide resolved
...uron-flink-runtime/src/test/java/org/apache/auron/flink/arrow/FlinkArrowFFIExporterTest.java
Outdated
Show resolved
Hide resolved
...on/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/FlinkArrowFFIExporter.java
Show resolved
Hide resolved
...ion/auron-flink-runtime/src/test/java/org/apache/auron/flink/arrow/FlinkArrowWriterTest.java
Outdated
Show resolved
Hide resolved
...on/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/FlinkArrowFFIExporter.java
Show resolved
Hide resolved
...on/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/FlinkArrowFFIExporter.java
Outdated
Show resolved
Hide resolved
...tension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/FlinkArrowWriter.java
Show resolved
Hide resolved
...on/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/FlinkArrowFFIExporter.java
Show resolved
Hide resolved
...on/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/FlinkArrowFFIExporter.java
Show resolved
Hide resolved
- Add try-finally resource protection in producer thread - Return false on InterruptedException to avoid deadlock - Fix comments: clarify nanoseconds vs microseconds - Add Javadoc for resource management
Contributor
|
@x-tong is it possible to split this up into separate PRs to make it easier to review? |
Author
I will do this this week. |
3 tasks
Author
|
@ShreyeshArangath I've split this PR into 3 smaller PRs for easier review:
I'll keep this PR open for reference until all parts are merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
./auron-build.sh --pre --sparkver 3.5 --scalaver 2.12 -DskipBuildNative./dev/reformatCloses #1850