[AURON #1778] Add spark.auron.expression.singleChildFallback.enabled config #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yew1eb
force-pushed
the
add_singleChildFallback
branch
from
418e057 to
e700f7c
Compare
richox
approved these changes
Dec 26, 2025
yew1eb
force-pushed
the
add_singleChildFallback
branch
from
e700f7c to
cba1e34
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configuration flag spark.auron.expression.singleChildFallback.enabled to allow users to disable the single-child fallback optimization in expression conversion. This addresses issue #1778, which requested the ability to disable this optimization when it introduces overhead or complicates debugging.
Changes:
- Added
singleChildFallbackEnabledconfiguration method that defaults totruefor backward compatibility - Modified
convertExprto check the config and skip single-child optimization when disabled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala
Show resolved
Hide resolved
Contributor
Author
|
@cxzl25 Could you help merge this PR? |
cxzl25
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1778
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?