Skip to content

Conversation

@emrekultursay
Copy link
Contributor

It seems vectorization is still not there in r30.

It seems vectorization is still not there in r30.
@gemini-code-assist
Copy link

Summary of Changes

Hello @emrekultursay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts a conditional compilation directive within the benchmark.cpp file, specifically raising the required NDK major version for a std::simd feature check. The modification reflects the current status where std::simd is not yet fully implemented or stable in NDK r30, thus postponing the associated compilation error to NDK r31.

Highlights

  • NDK Version Update: The conditional compilation check for std::simd support has been updated from __NDK_MAJOR__ >= 29 to __NDK_MAJOR__ >= 31.
  • Vectorization Support: This change indicates that std::simd is still not fully supported or available in NDK r30, necessitating the deferral of the check to a later NDK version.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NDK version check for std::simd from version 29 to 31. The change correctly reflects the information in the PR description that this feature is not yet available in NDK r30. My only suggestion is to update the PR title to mention 'NDK r31' instead of 'NDK r30' to avoid confusion and maintain a clear commit history.

@emrekultursay emrekultursay changed the title Raise the vectorization #if to NDK r30 Raise the vectorization #if to NDK r31 Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants