Support camera callback parameter added in r30

[emrekultursay]

Without this change, build fails with NDK r30 due to missing field in initialization of the ACameraDevice_stateCallbacks object.

[gemini-code-assist]

Summary of Changes

Hello @emrekultursay, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues with newer Android NDK versions by introducing a required camera device callback for NDK r30 and updating a version-specific check related to C++ SIMD features. The changes ensure that applications can build successfully with NDK r30 and anticipate future NDK updates for standard library features.

Highlights

• NDK r30 Camera Callback Support: Added conditional compilation to include the onClientSharedAccessPriorityChanged callback in ACameraDevice_stateCallbacks for NDK versions 30 and above. This resolves build failures when compiling with NDK r30 due to a missing field.
• NDK Version Check Update: Updated the NDK major version check for std::simd support in benchmark.cpp from __NDK_MAJOR__ >= 29 to __NDK_MAJOR__ >= 31, indicating an expectation for std::simd to be more mature in future NDK releases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for a new camera callback parameter introduced in NDK r30, which fixes a build failure. The changes are applied to two camera sample applications, and another file is updated to reflect NDK version changes. My feedback focuses on improving the readability and maintainability of the new callback implementation by naming its parameters for consistency with the existing code.

[emrekultursay]

Do you need to hit some button to unblock the presubmit?