Open
Conversation
repa4ok
commented
Apr 4, 2017
- bt_backend:more convenient canonical_url: from my point of view it is more convenient to use 'canonical_url' provided by plugin, not those one constructed dynamically. also, new constructed url passed to backend_play_video, so probably it is possible to update playing count for both urls.
- es_string: fix for "utf-8" encoding: I'm experiencing error with handling one URL because it returns charset as "utf-8" (with quotes). it would be nice if you know a better way to fix that :)
- es_string: fix for "utf-8" encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.