fix warning: implicit declaration of function ‘strcasecmp’#546
Open
andy5995 wants to merge 1 commit intoandlabs:masterfrom
andy5995:fix-strcasecmp-warning
Open
fix warning: implicit declaration of function ‘strcasecmp’#546andy5995 wants to merge 1 commit intoandlabs:masterfrom andy5995:fix-strcasecmp-warning
andy5995 wants to merge 1 commit intoandlabs:masterfrom
andy5995:fix-strcasecmp-warning
Conversation
On gcc 11.1.0 (Manjaro), I got this warning
```
[58/93] Compiling C object meson-out/libui.so.0.p/unix_text.c.o
../unix/text.c: In function ‘uiprivStricmp’:
../unix/text.c:16:16: warning: implicit declaration of function
‘strcasecmp’; did you mean ‘g_strcasecmp’?
[-Wimplicit-function-declaration]
16 | return strcasecmp(a, b);
| ^~~~~~~~~~
| g_strcasecmp
```
I assume you'd want to use a g_* function here so you don't have to
Apparently g_strcasecmp is deprecated. Some extra info at
https://people.gnome.org/~ryanl/glib-docs/glib-String-Utility-Functions.html#g-strcasecmp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On gcc 11.1.0 (Manjaro), I got this warning
I assume you'd want to use a g_* function here so you don't have to
Apparently g_strcasecmp is deprecated. Some extra info at
https://people.gnome.org/~ryanl/glib-docs/glib-String-Utility-Functions.html#g-strcasecmp