darwin: Fix uiTable checkbox change not calling SetCellValue().#509
Open
szanni wants to merge 1 commit intoandlabs:masterfrom
Open
darwin: Fix uiTable checkbox change not calling SetCellValue().#509szanni wants to merge 1 commit intoandlabs:masterfrom
szanni wants to merge 1 commit intoandlabs:masterfrom
Conversation
The SetCellValue() when clicking a checkbox within a uiTable is never called. The UI happiliy updates suggesting the value has been set - which is not actually the case. The checkbox not redrawing with the actual check box value from the model is another related issue, see andlabs#507.
szanni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something that came up while trying things out with the new tester for uiTable suggested in #508:
The SetCellValue() when clicking a checkbox within a uiTable is never called.
The UI happiliy updates suggesting the value has been set - which is not actually the case.
The checkbox not redrawing with the actual check box value from the model is another related issue, see #507.
As a general question regarding PRs fixing issues: should I open a separate issue every time? Or is the PR fixing the issue enough? I couldn't find anything in CONTRIBUTING.md