Implement proper uiTableModel stamps for unix.#505
Open
szanni wants to merge 2 commits intoandlabs:masterfrom
Open
Implement proper uiTableModel stamps for unix.#505szanni wants to merge 2 commits intoandlabs:masterfrom
szanni wants to merge 2 commits intoandlabs:masterfrom
Conversation
- Make model stamps random on init. - Use g_return_*_if_fail functions to log errors of invalid stamp use.
Remove the iter stamp check from uiTableModel_iter_nth_child: This is a setter for iter, so no checks should be performed. As reference: both GtkListStore and GtkTreeStore do not perform any checks on iter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unix:
The logging actually brought up issue #504. The second commit in this pr fixes that issue.
The dynamic iter stamps are additionally a stepping stone for a sort model - hopefully soon to come.