[NOT FOR MERGE YET] Cache under api try2 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from *isyntax. streamer not updated.
alex-virodov
commented
May 18, 2023
| isyntax_tile_t* tile = level->tiles + j; | ||
| for (i32 color = 0; color < 3; ++color) { | ||
| isyntax_tile_channel_t* channel = tile->color_channels + color; | ||
| if (channel->coeff_ll) free(channel->coeff_ll); |
Collaborator
Author
There was a problem hiding this comment.
this needs to be block_free...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Falcury can you PTAL? If we commit to global-only cache, I can keep it restricted mostly to libisyntax level. If we want per-isyntax cache, I need to be able to put a cache pointer in isyntax_t, and that makes things much more complicated [Edit: not much, see https://github.com/amspath/libisyntax/tree/cache-under-api-try3, very wip]. As I mentioned in (#4 (comment)), I don't see much use for per-isyntax cache, but please let me know if I'm missing something.
And you can still have no cache at all, and per-isyntax allocators if you are skipping the libisyntax layer.
I still need to figure out proper locking, so not ready for merge. Please let me know if this is a bad direction to take.