Conversation
alejandrodevs
force-pushed
the
remove-depracations-and-fix-tests
branch
from
062c487 to
cd574d7
Compare
alejandrodevs
changed the title
|
|
||
| module Dolly | ||
| class Collection < DelegateClass(Array) | ||
| class Collection < SimpleDelegator |
There was a problem hiding this comment.
there's no issue with previous versions of ruby with this change?
There was a problem hiding this comment.
It behaves the same and SimpleDelegator is available since ruby 2.4 if I'm not wrong.
There was a problem hiding this comment.
If this changes rules out some versions of Ruby, then that should be reflected in the version... This should probably be done on a new branch or something as it would be a breaking change for applications using older rubies
|
|
||
| module Dolly | ||
| class Collection < DelegateClass(Array) | ||
| class Collection < SimpleDelegator |
There was a problem hiding this comment.
If this changes rules out some versions of Ruby, then that should be reflected in the version... This should probably be done on a new branch or something as it would be a breaking change for applications using older rubies
3 participants
Actions: