Fix issue with nil properties not being set and passing hash with string keys issue#164
Merged
ErickFabian merged 4 commits into3.1from May 11, 2021
Merged
Fix issue with nil properties not being set and passing hash with string keys issue#164ErickFabian merged 4 commits into3.1from
ErickFabian merged 4 commits into3.1from
Conversation
javierg
requested changes
Apr 14, 2021
Member
javierg
left a comment
javierg
left a comment
There was a problem hiding this comment.
These are 2 issues, can you create 2 different PRs?
Contributor
Author
Member
|
@ErickFabian can you write a test please. I am not sure if this change will make any missing attribute on the model being removed. |
Contributor
Author
|
@javierg I've added a spec for setting nil to a property on a doc |
javierg
reviewed
May 11, 2021
test/property_manager_test.rb
Outdated
|
|
||
| class PropertyManagerTest < Test::Unit::TestCase | ||
| test 'write_attribute with nil value' do | ||
| doc = TestDoc.new(name: 'name') |
Member
There was a problem hiding this comment.
please add more properties, other than the one being updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: