Open
Conversation
javierg
reviewed
Mar 30, 2021
| module Request | ||
| def set_namespace name | ||
| @namespace = name | ||
| def set_db_namespace(name) |
Member
There was a problem hiding this comment.
this is a breaking change, why is the change being done?
Contributor
Author
There was a problem hiding this comment.
set_namespace makes me understand that the model will set the document namespace, the part of user/ not choose which database the model will connect to
javierg
requested changes
Mar 30, 2021
Member
javierg
left a comment
javierg
left a comment
There was a problem hiding this comment.
I guess we need to discuss why this change is needed as it is a braking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors set_namespace method to avoid method clashes and introduces collection_view method into the base methods of a dolly document