Open
Conversation
seancookr
reviewed
Aug 17, 2018
lib/dolly/property.rb
Outdated
| attr_reader :class_name, :default | ||
|
|
||
| CANT_CLONE = [NilClass, TrueClass, FalseClass, Fixnum].freeze | ||
| CANT_CLONE = [NilClass, TrueClass, FalseClass, Integer].freeze |
There was a problem hiding this comment.
I think this, in order to be useful in a lot of places, should be determined based on the version of ruby (as I think that is the change in this no?)
Member
Author
There was a problem hiding this comment.
mmh, right, this is not related to the ruby version
will remove the change as it is not related to the errors associated to httparty parsed response
There was a problem hiding this comment.
👍 ya i think a PR for that on its own makes sense. I could see a singleton of a DelegateClass Array here as a feasible way to handle that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR to make Dolly compatible with 2.0
And actually this is the minimal to make it work.
This is fixing the crash due to fix on httparty response handle of couchdb 2.0 requests which now inckude proper headers to accept them as json.