Skip to content

Resolve issue #67: Night mode always do flash on Xiaomi Redmi Note 4 (mido) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lupaglio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolve issue #67: Night mode always do flash on Xiaomi Redmi Note 4 (mido) #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32288e2
Added the isXiaomiRedmiNote4 variable
lupaglio Feb 2, 2018
351fd85
Don't apply CameraParameters.SCENE_MODE_NIGHT if isXiaomiRedmiNote4
lupaglio Feb 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/com/almalence/opencam/cameracontroller/CameraController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,8 @@ public class CameraController implements Camera.PictureCallback, Camera.AutoFocu
public static boolean isPixel = Build.MANUFACTURER.toLowerCase().replace(" ", "").contains("google")
&& Build.MODEL.toLowerCase().replace(" ", "").contains("pixel");

public static boolean isXiaomiRedmiNote4 = Build.MODEL.toLowerCase(Locale.US).replace(" ", "").contains("redminote4");

public static boolean motozChangeResolution = false;

// Android camera parameters constants
Expand Down
2 changes: 1 addition & 1 deletion src/com/almalence/plugins/capture/night/NightCapturePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ public void setupCameraParameters()
// exlude also LG G3 and some others modifications to prevent camera error in takePicture call.
// FixMe: probably Nexus should not be excluded if using Camera2 interface
if (sceneModes != null && CameraController.isModeAvailable(sceneModes, CameraParameters.SCENE_MODE_NIGHT)
&& (!CameraController.isNexus && !CameraController.isG3) && !usingSuperMode)
&& (!CameraController.isNexus && !CameraController.isG3 && !CameraController.isXiaomiRedmiNote4) && !usingSuperMode)
{
CameraController.setCameraSceneMode(CameraParameters.SCENE_MODE_NIGHT);
ApplicationScreen.instance.setSceneModePref(CameraParameters.SCENE_MODE_NIGHT);
Expand Down