Bug fix (choice of linear forms in the non-radical case) #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerebertho
reviewed
Jan 23, 2026
Contributor
There was a problem hiding this comment.
You might be able to simplify the function equal_param by calling nmod_poly_equal on param->coords[i] and test_param->coords[i] in the outer loop.
See below.
| *bsz, *nlins_ptr, linvars, lineqs_ptr[0], squvars, | ||
| 0, bdata_fglm, bdata_bms, success, md); | ||
| int boo = equal_param(*bparam, *test_nmod_param); | ||
| if(boo == 0){ |
Contributor
There was a problem hiding this comment.
Suggested change
| if(boo == 0){ | |
| if(! boo){ |
| test/diff/diff_reals_dim0-chgvar.sh \ | ||
| test/diff/diff_reals_dim0-extract.sh \ | ||
| test/diff/diff_reals_dim0-swapvar.sh \ | ||
| test/diff/diff_choice-linear-form.sh \ |
Contributor
There was a problem hiding this comment.
Suggested change
| test/diff/diff_choice-linear-form.sh \ | |
| test/diff/diff_choice-linear-form-qq.sh \ |
| test/diff/diff_reals_dim0-extract.sh \ | ||
| test/diff/diff_reals_dim0-swapvar.sh \ | ||
| test/diff/diff_choice-linear-form.sh \ | ||
| test/diff/diff_choice-linear-form-real-roots.sh \ |
Contributor
There was a problem hiding this comment.
Suggested change
| test/diff/diff_choice-linear-form-real-roots.sh \ | |
| test/diff/diff_choice-linear-form-qq-real-roots.sh \ |
| test/diff/diff_radical_shape-qq.sh:test/diff/diff_radical_shape-qq.sh | ||
| input_files/choice-linear-form-qq.ms:input_files/choice-linear-form-qq.ms | ||
| output_files/choice-linear-form-qq.res:output_files/choice-linear-form-qq.res | ||
| test/diff/diff_choice-linear-form.sh:test/diff/diff_choice-linear-form.sh |
Contributor
There was a problem hiding this comment.
Suggested change
| test/diff/diff_choice-linear-form.sh:test/diff/diff_choice-linear-form.sh | |
| test/diff/diff_choice-linear-form-qq.sh:test/diff/diff_choice-linear-form-qq.sh |
| test/diff/diff_choice-linear-form.sh:test/diff/diff_choice-linear-form.sh | ||
| input_files/choice-linear-form-qq-real-roots.ms:input_files/choice-linear-form-qq-real-roots.ms | ||
| output_files/choice-linear-form-qq-real-roots.res:output_files/choice-linear-form-qq-real-roots.res | ||
| test/diff/diff_choice-linear-form-real-roots.sh:test/diff/diff_choice-linear-form-real-roots.sh |
Contributor
There was a problem hiding this comment.
Suggested change
| test/diff/diff_choice-linear-form-real-roots.sh:test/diff/diff_choice-linear-form-real-roots.sh | |
| test/diff/diff_choice-linear-form-qq-real-roots.sh:test/diff/diff_choice-linear-form-qq-real-roots.sh |
| * */ | ||
| static int equal_param(param_t *param, param_t *test_param){ | ||
| for(int i = 0; i < param->nvars-1; i++){ | ||
| if(param->coords[i]->length != test_param->coords[i]->length){ |
Contributor
There was a problem hiding this comment.
Suggested change
| if(param->coords[i]->length != test_param->coords[i]->length){ | |
| if(! nmod_poly_equal (param->coords[i], test_param->coords[i])){ | |
| return 0; | |
| } |
and then remove everything below until the end of the outer loop.
Disclaimer: this should be tested.
Contributor
There was a problem hiding this comment.
Rename test/diff/diff_choice-linear-form-qq-real-roots.sh
Contributor
There was a problem hiding this comment.
Rename test/diff/diff_choice-linear-form-qq.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug occurring for non radical ideals (when the radical is not in shape position).
The bug was precisely in the choice of new linear forms to be introduced.