Open
Conversation
This prevented installing the SDK on some systems such as Nix 24.05.
|
"summary": "This PR involves a minor update to the dependencies list in pyproject.toml. The changes from specific versions (4.3.1 and 6.3.0) to more general versions (eth_typing>=4.0.0 and web3>=6.3.0) are likely to be non-breaking and do not introduce significant risks. The update is focused on flexibility and compatibility, which aligns with the 'BLUE' category, indicating a low complexity PR.", |
Psycojoker
requested changes
Sep 18, 2024
| "aioresponses>=0.7.6", | ||
| "aleph-superfluid>=0.2.1", | ||
| "eth_typing==4.3.1", | ||
| "web3==6.3.0", |
Collaborator
There was a problem hiding this comment.
We want to add an upper bound version to enforce semver to avoid randomly breaking our installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevented installing the SDK on some systems
such as Nix 24.05.