fix: use str instead of float to preserve precision #151
Draft
Conversation
|
Summary: Highlight: - required_tokens: float
+ required_tokens: strThis change is straightforward and does not affect the overall functionality of the codebase, making it suitable for a routine review. |
Member
Author
|
Unit test should work need PR merge |
Member
|
Converted to Draft, this should use the Decimal type in Python and ensuring that the upstream API returns the expected type. |
hoh
reviewed
Aug 20, 2024
Co-authored-by: Hugo Herter <git@hugoherter.com>
f0f6a94 to
e9d98f8
Compare
Collaborator
|
Apparently the other PR has been merged, should we resume this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where using float to represent certain numerical values resulted in loss of precision due to rounding. By switching to str, we can maintain the exact value without rounding errors.